[ 
https://issues.apache.org/jira/browse/FLINK-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16171641#comment-16171641
 ] 

ASF GitHub Bot commented on FLINK-7534:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4603#discussion_r139684917
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/RedirectHandler.java
 ---
    @@ -143,19 +154,20 @@ protected void channelRead0(
                                                        routed.request(),
                                                        new 
ErrorResponseBody("Service temporarily unavailable due to an ongoing leader 
election. Please refresh."),
                                                        
HttpResponseStatus.SERVICE_UNAVAILABLE));
    -                   } else {
    -                           HandlerUtils.sendErrorResponse(
    -                                   channelHandlerContext,
    -                                   routed.request(),
    -                                   new ErrorResponseBody("Local address 
has not been resolved. This indicates an internal error."),
    -                                   
HttpResponseStatus.INTERNAL_SERVER_ERROR);
    +
    +                   } catch (Throwable throwable) {
    +                           logger.warn("Error occurred while processing 
web request.", throwable);
    +                                   HandlerUtils.sendErrorResponse(
    --- End diff --
    
    Good catch.


> Create LegacyRestHandlerAdapter for the old REST handlers
> ---------------------------------------------------------
>
>                 Key: FLINK-7534
>                 URL: https://issues.apache.org/jira/browse/FLINK-7534
>             Project: Flink
>          Issue Type: Sub-task
>          Components: REST, Webfrontend
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>              Labels: flip-6
>
> Create a {{LegacyRestHandlerAdapter}} to integrate the old REST handler with 
> the new {{RestServerEndpoint}} and the {{AbstractRestHandler}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to