[
https://issues.apache.org/jira/browse/FLINK-7575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16161607#comment-16161607
]
ASF GitHub Bot commented on FLINK-7575:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4647#discussion_r138133763
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/utils/MutableIOMetrics.java
---
@@ -99,11 +140,35 @@ public void addIOMetrics(AccessExecution attempt,
@Nullable MetricFetcher fetche
* @throws IOException
*/
public void writeIOMetricsAsJson(JsonGenerator gen) throws IOException {
+ /**
+ * Ask describe in the addIOMetrics, we want to distinguish
incomplete values from 0.
--- End diff --
typo: ask -> as
remote "the" before addIOMetrics
could use ```@link annotation for the method```
> Dashboard jobs/tasks metrics display 0 when metrics are not yet available
> -------------------------------------------------------------------------
>
> Key: FLINK-7575
> URL: https://issues.apache.org/jira/browse/FLINK-7575
> Project: Flink
> Issue Type: Improvement
> Components: Webfrontend
> Affects Versions: 1.3.2
> Reporter: James Lafa
> Assignee: James Lafa
> Priority: Minor
>
> The web frontend is currently displaying "0" when a metric is not available
> yet (ex: records-in/out, bytes-in/out).
> 0 is misleading and it's preferable to display no value while the value is
> still unknown.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
