[
https://issues.apache.org/jira/browse/FLINK-7575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154964#comment-16154964
]
ASF GitHub Bot commented on FLINK-7575:
---------------------------------------
Github user uce commented on the issue:
https://github.com/apache/flink/pull/4647
Thanks @zentol for the review.
@jameslafa
- Regarding the first point with checkstyle: It's confusing that our
checkstyle settings don't catch this, but Chesnay is right here. Seems nitpicky
but we try to avoid unnecessary formatting changes.
- Regarding the changes to the *.js files: Since you didn't change any of
the coffee scripts, there should be no need to commit those files and I would
also suggest to remove those changes. The changes are probably due to different
versions on your machine and the previous contributor who changed the files. I
think this only reinforces the argument we had about committing the *.lock file
too. Could you create a new JIRA for this?
@zentol
- I didn't understand your follow up comments regarding the
`metricsFetched` flag. Could you please elaborate on what you mean? Is the flag
ok to keep after #4472 is merged?
> Dashboard jobs/tasks metrics display 0 when metrics are not yet available
> -------------------------------------------------------------------------
>
> Key: FLINK-7575
> URL: https://issues.apache.org/jira/browse/FLINK-7575
> Project: Flink
> Issue Type: Improvement
> Components: Webfrontend
> Affects Versions: 1.3.2
> Reporter: James Lafa
> Assignee: James Lafa
> Priority: Minor
>
> The web frontend is currently displaying "0" when a metric is not available
> yet (ex: records-in/out, bytes-in/out).
> 0 is misleading and it's preferable to display no value while the value is
> still unknown.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
