[ https://issues.apache.org/jira/browse/FLINK-7381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116745#comment-16116745 ]
ASF GitHub Bot commented on FLINK-7381: --------------------------------------- Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4492#discussion_r131683814 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/WebMonitorOptions.java --- @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.configuration; + +import org.apache.flink.annotation.PublicEvolving; + +/** + * Configuration options for the WebRuntimeMonitor + */ +@PublicEvolving +public class WebMonitorOptions { + + /** + * Timeout for asynchronous operations by the WebRuntimeMonitor + */ + public static final ConfigOption<Long> WEB_TIMEOUT = ConfigOptions + .key("web.timeout") --- End diff -- this config key is inconsistent with the existing web monitor options, > Decouple WebRuntimeMonitor from ActorGateway > -------------------------------------------- > > Key: FLINK-7381 > URL: https://issues.apache.org/jira/browse/FLINK-7381 > Project: Flink > Issue Type: Sub-task > Components: Webfrontend > Affects Versions: 1.4.0 > Reporter: Till Rohrmann > Assignee: Till Rohrmann > Labels: flip-6 > > The {{WebRuntimeMonitor}} has a hard wired dependency on the {{ActorGateway}} > in order to communicate with the {{JobManager}}. In order to make it work > with the {{JobMaster}} (Flip-6), we have to abstract this dependency away. I > propose to add a {{JobManagerGateway}} interface which can be implemented > using Akka for the old {{JobManager}} code. The Flip-6 {{JobMasterGateway}} > can then directly inherit from this interface. -- This message was sent by Atlassian JIRA (v6.4.14#64029)