[
https://issues.apache.org/jira/browse/FLINK-7381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116654#comment-16116654
]
ASF GitHub Bot commented on FLINK-7381:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/4492
[FLINK-7381] [web] Decouple WebRuntimeMonitor from ActorGateway
## What is the purpose of the change
This PR decouples the `WebRuntimeMonitor` from the `ActorGateway` by
introducing the `JobManagerGateway` interface which can have multiple
implementations. This is a preliminary step for the integration of the existing
`WebRuntimeMonitor` with the Flip-6 `JobMaster`.
This PR is based #4486.
## Brief change log
- Extending the `JobManagerGateway` with methods to cover the requirements
of the `WebRuntimeMonitor`
- Change `JobManagerRetriever` to return `JobManagerGateway` instead of
`Tuple2<ActorGateway, Integer>`
- Adapt handlers to use the `JobManagerRetriever`
- Introduce `MetricQueryServiceRetriever` to retrieve `MetricQueryService`
implementations running alongside with the JM and TM
- Introduce `MetricQueryServiceGateway` to abstract the implementation
details of the `MetricQueryService` (e.g. Akka based)
- Pass `MetricQueryServiceRetriever` to `WebRuntimeMonitor` and
`MetricFetcher`
- Adapt test classes to work with newly introduced interfaces
- Add `web.timeout` configuration option to control the WebRuntimeMonitor
timeouts (see `WebMonitorOptions#WEB_TIMEOUT`
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (nop)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink webMonitorFlip6
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4492.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4492
----
commit 50d304647e65be90937809d71cef87608f60b9ce
Author: Till Rohrmann <trohrm...@apache.org>
Date: 2017-08-04T22:28:15Z
[FLINK-7372] [JobGraph] Remove ActorGateway from JobGraph
The JobGraph has an unncessary dependency on the ActorGateway via its
JobGraph#uploadUserJars method. In
order to get rid of this dependency for future Flip-6 changes, this commit
retrieves the BlobServer's
address beforehand and directly passes it to this method.
commit e4596e060b471464064de142d16d86c0a52ca078
Author: Till Rohrmann <trohrm...@apache.org>
Date: 2017-08-06T15:56:41Z
[FLINK-7375] Replace ActorGateway with JobManagerGateway in JobClient
In order to make the JobClient code independent of Akka, this PR replaces
the
ActorGateway parameters by JobManagerGateway. AkkaJobManagerGateway is the
respective implementation of the JobManagerGateway for Akka. Moreover, this
PR introduces useful ExceptionUtils method for handling of Future
exceptions.
Additionally, the SerializedThrowable has been moved to flink-core.
commit c88b83db49d0f6f45578e7563e3dd7e28c3a24d3
Author: Till Rohrmann <trohrm...@apache.org>
Date: 2017-08-02T16:43:00Z
[FLINK-7381] [web] Decouple WebRuntimeMonitor from ActorGateway
----
> Decouple WebRuntimeMonitor from ActorGateway
> --------------------------------------------
>
> Key: FLINK-7381
> URL: https://issues.apache.org/jira/browse/FLINK-7381
> Project: Flink
> Issue Type: Sub-task
> Components: Webfrontend
> Affects Versions: 1.4.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Labels: flip-6
>
> The {{WebRuntimeMonitor}} has a hard wired dependency on the {{ActorGateway}}
> in order to communicate with the {{JobManager}}. In order to make it work
> with the {{JobMaster}} (Flip-6), we have to abstract this dependency away. I
> propose to add a {{JobManagerGateway}} interface which can be implemented
> using Akka for the old {{JobManager}} code. The Flip-6 {{JobMasterGateway}}
> can then directly inherit from this interface.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
