[
https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116520#comment-16116520
]
ASF GitHub Bot commented on FLINK-7337:
---------------------------------------
GitHub user fhueske opened a pull request:
https://github.com/apache/flink/pull/4488
[FLINK-7337] [table] Refactor internal handling of time indicator
attributes.
## What is the purpose of the change
Handle time indicators attributes as physical fields in `Row`.
- support for multiple event-time time attributes (required for proper join
handling)
- no distinction of logical and physical schema
## Brief change log
- Expand phyiscal Row schema for time indicators.
- Refactor computation of logical schema of tables to import.
- `StreamRecord` timestamps are moved into `Row` during initial conversion
- Refactor operators to use time attribute in Row instead of StreamRecord
timestamp.
- timestamps are copied into `StreamRecord` when `Table` is converted into
`DataStream`.
- Drive-by fix for NPE in `generateInputFieldUnboxing`
## Verifying this change
- Changes are mostly internal.
- No new features or public APIs have been added.
- All existing tests pass.
- Tests have been added to verify that time indicators are copied when
`Table` is converted into `DataStream`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **yes**
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
## Documentation
- Does this pull request introduce a new feature? **no**
- If yes, how is the feature documented? **na**
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fhueske/flink tableTimeIndi
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4488.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4488
----
commit accf80587b5a7455fb913b5860f973b3a738765a
Author: Fabian Hueske <fhue...@apache.org>
Date: 2017-08-04T00:20:56Z
[FLINK-7337] [table] Refactor internal handling of time indicator
attributes.
- Expand phyiscal Row schema for time indicators.
- Refactor computation of logical schema of tables to import.
- Refactor operators to use time attribute in Row instead of StreamRecord
timestamp.
----
> Refactor handling of time indicator attributes
> ----------------------------------------------
>
> Key: FLINK-7337
> URL: https://issues.apache.org/jira/browse/FLINK-7337
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Affects Versions: 1.4.0
> Reporter: Fabian Hueske
> Assignee: Fabian Hueske
>
> After a [discussion on the dev mailing
> list|https://lists.apache.org/thread.html/735d55f9022df8ff73566a9f1553e14be94f8443986ad46559b35869@%3Cdev.flink.apache.org%3E]
> I propose the following changes to the current handling of time indicator
> attributes:
> * Remove the separation of logical and physical row type.
> ** Hold the event-time timestamp as regular Long field in Row
> ** Represent the processing-time indicator type as a null-valued field in Row
> (1 bit overhead)
> * Remove materialization of event-time timestamps because timestamp is
> already accessible in Row.
> * Add {{ProcessFunction}} to set timestamp into the timestamp field of a
> {{StreamRecord}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
