Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r130461621
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -405,6 +481,17 @@ class AggregationCodeGenerator(
}
}
+ val aggFuncCode = Seq(
+ genSetAggregationResults,
+ genAccumulate,
+ genRetract,
+ genCreateAccumulators,
+ genSetForwardedFields,
+ genSetConstantFlags,
+ genCreateOutputRow,
+ genMergeAccumulatorsPair,
+ genResetAccumulator).mkString("\n")
--- End diff --
I think we need an additional `cleanUp()` method that clears all state
objects for the current key. Otherwise, we will have memory leaks. The
`cleanUp()` method must be called when the state retention timers trigger.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
