Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4355#discussion_r130461181
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -386,13 +455,20 @@ class AggregationCodeGenerator(
val sig: String =
j"""
| public final void resetAccumulator(
- | org.apache.flink.types.Row accs)""".stripMargin
+ | org.apache.flink.types.Row accs) throws Exception
""".stripMargin
val reset: String = {
- for (i <- aggs.indices) yield
+ for (i <- aggs.indices) yield {
+ val setDataView = if (accConfig.isDefined &&
accConfig.get.isUseState) {
+ genDataViewFieldSetter(s"acc$i", accConfig.get.accSpecs(i))
--- End diff --
Should reuse the state objects.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
