Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r130058073
--- Diff:
flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerThread.java
---
@@ -308,17 +311,33 @@ public void shutdown() {
*
* <p>Only one commit operation may be pending at any time. If the
committing takes longer than
* the frequency with which this method is called, then some commits
may be skipped due to being
- * superseded by newer ones.
+ * superseded by newer ones.
*
* @param offsetsToCommit The offsets to commit
*/
public void setOffsetsToCommit(Map<TopicPartition, OffsetAndMetadata>
offsetsToCommit) {
--- End diff --
I don't think we need this variant anymore. The only user of the method is
`Kafka09Fetcher`, anyways.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
