Github user zhenzhongxu commented on a diff in the pull request:
https://github.com/apache/flink/pull/4187#discussion_r127838984
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
---
@@ -185,6 +187,18 @@
private volatile boolean running = true;
//
------------------------------------------------------------------------
+ // internal metrics
+ //
------------------------------------------------------------------------
+
+ /** Counter for successful Kafka offset commits. */
+ private transient Counter successfulCommits;
+
+ /** Counter for failed Kafka offset commits. */
+ private transient Counter failedCommits;
+
+ private transient KafkaCommitCallback offsetCommitCallback;
--- End diff --
Sounds fair, I'll include a javadoc as well a notice about the
thread-safety contract as you suggested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
