Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r126412849
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -187,35 +252,122 @@ public void testUnrequestedShort() {
// test repeated access
Assert.assertEquals(2, parameter.getShort("short"));
+ Assert.assertEquals(Collections.emptySet(),
parameter.getUnrequestedParameters());
+ }
+
+ @Test
+ public void testUnrequestedShortWithDefaultValue() {
+ ParameterTool parameter = ParameterTool.fromArgs(new
String[]{"-short", "2"});
+ Assert.assertEquals(Sets.newHashSet("short"),
parameter.getUnrequestedParameters());
+
+ // test parameter access
+ Assert.assertEquals(2, parameter.getShort("short", (short) 0));
+ Assert.assertEquals(Collections.emptySet(),
parameter.getUnrequestedParameters());
+
+ // test repeated access
+ Assert.assertEquals(2, parameter.getShort("short", (short) 0));
+ Assert.assertEquals(Collections.emptySet(),
parameter.getUnrequestedParameters());
}
@Test
+ public void testUnrequestedShortWithMissingValue() {
+ ParameterTool parameter = ParameterTool.fromArgs(new
String[]{"-short"});
+ Assert.assertEquals(Sets.newHashSet("short"),
parameter.getUnrequestedParameters());
+
+ exception.expect(RuntimeException.class);
+ exception.expectMessage("For input string: \"__NO_VALUE_KEY\"");
+
+ parameter.getShort("short");
+ Assert.assertEquals(Collections.emptySet(),
parameter.getUnrequestedParameters());
+ }
+
+ // Int
+
+ @Test
public void testUnrequestedInt() {
ParameterTool parameter = ParameterTool.fromArgs(new
String[]{"-int", "4"});
Assert.assertEquals(Sets.newHashSet("int"),
parameter.getUnrequestedParameters());
// test parameter access
- Assert.assertEquals(4, parameter.getByte("int"));
+ Assert.assertEquals(4, parameter.getInt("int"));
--- End diff --
nice catch, didn't see this one before
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
