Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4169#discussion_r126413188
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
@@ -278,6 +518,26 @@ public void testUnrequestedRequired() {
// test repeated access
Assert.assertEquals("â", parameter.getRequired("required"));
+ Assert.assertEquals(Collections.emptySet(),
parameter.getUnrequestedParameters());
+ }
+
+ @Test
+ public void testUnrequestedMultiple() {
+ ParameterTool parameter = ParameterTool.fromArgs(new
String[]{"-boolean", "true", "-byte", "1",
+ "-short", "2", "-int", "4", "-long", "8", "-float",
"4.0", "-double", "8.0", "-string", "â"});
+ Assert.assertEquals(Sets.newHashSet("boolean", "byte", "short",
"int", "long", "float", "double", "string"),
+ parameter.getUnrequestedParameters());
+
+ Assert.assertTrue(parameter.getBoolean("boolean"));
--- End diff --
can you add some `assert`s for the unrequested parameters in between the
getters?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
