Github user mpouttuclarke commented on a diff in the pull request:
https://github.com/apache/flink/pull/4228#discussion_r125073534
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/KinesisConfigUtil.java
---
@@ -171,7 +172,14 @@ public static void validateAwsConfiguration(Properties
config) {
}
if (!config.containsKey(AWSConfigConstants.AWS_REGION)) {
--- End diff --
The new constructors make the easy path the right path. We go through a
lot of trouble at Amazon to make sure that the default constructors do the
right thing with the minimal amount of effort. Yet people still set things
like region and auth manually when it is not only unnecessary but also a
security, performance, and compliance risk. Wherever we can we should try to
follow the example of the AWS SDK and provide for using it correctly. Overall,
I would make the argument that using property files and statics isn't a best
practice. There really should be type safe POJOs and dependency injection in
place for configuration of the consumer but that is a larger issue than I can
take on right now. The new constructors attempt to add some type safety while
improving ease of use when operating in an Amazon environment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
