Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4228#discussion_r124967289
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/KinesisConfigUtil.java
---
@@ -171,7 +172,14 @@ public static void validateAwsConfiguration(Properties
config) {
}
if (!config.containsKey(AWSConfigConstants.AWS_REGION)) {
--- End diff --
I wonder if its actually sufficient to rely on this check, without having
the need to have a bunch of the new constructors that you added.
I.e., it is sufficient that the user doesn't supply a
`AWSConfigConstants.AWS_REGION` value in the props, which we would then default
to using `Regions.getCurrentRegion()`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
