[ https://issues.apache.org/jira/browse/FLINK-7014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16065854#comment-16065854 ]
ASF GitHub Bot commented on FLINK-7014: --------------------------------------- Github user Xpray commented on a diff in the pull request: https://github.com/apache/flink/pull/4200#discussion_r124442541 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/datastream/DataStreamUserDefinedFunctionITCase.scala --- @@ -230,6 +231,26 @@ class DataStreamUserDefinedFunctionITCase extends StreamingMultipleProgramsTestB assertEquals(expected.sorted, StreamITCase.testResults.sorted) } + + @Test + def testScalarFunctionDeterministic(): Unit = { --- End diff -- thanks for reviewing, I'll add more test cases in `ExpressionReductionTest ` > Expose isDeterministic interface to ScalarFunction and TableFunction > -------------------------------------------------------------------- > > Key: FLINK-7014 > URL: https://issues.apache.org/jira/browse/FLINK-7014 > Project: Flink > Issue Type: Improvement > Components: Table API & SQL > Reporter: Ruidong Li > Assignee: Ruidong Li > > Currently, the `isDeterministic` method of implementations of `SqlFuntion` > are always returning true, which cause inappropriate optimization in Calcite, > such as taking user's stateful UDF as a pure functional procedure. -- This message was sent by Atlassian JIRA (v6.4.14#64029)