[ 
https://issues.apache.org/jira/browse/FLINK-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15984933#comment-15984933
 ] 

ASF GitHub Bot commented on FLINK-6250:
---------------------------------------

Github user huawei-flink commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3771#discussion_r113471605
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
 ---
    @@ -335,14 +371,28 @@ class CodeGenerator(
             j"""
                 |  public final void accumulate(
                 |    org.apache.flink.types.Row accs,
    -            |    org.apache.flink.types.Row input)""".stripMargin
    +            |    org.apache.flink.types.Row input) throws 
Exception""".stripMargin
     
           val accumulate: String = {
             for (i <- aggs.indices) yield
    -          j"""
    +         if(distinctAggsFlags(i)){
    +           j"""
    +              |  Long distValCount$i = (Long) 
distStateList[$i].get(${parameters(i)});
    +              |  if( distValCount$i == null){
    --- End diff --
    
    In scala it is 0L, is Java it is null. :-/


> Distinct procTime with Rows boundaries
> --------------------------------------
>
>                 Key: FLINK-6250
>                 URL: https://issues.apache.org/jira/browse/FLINK-6250
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: radu
>            Assignee: Stefano Bortoli
>
> Support proctime with rows boundaries
> Q1.1. `SELECT SUM( DISTINCT  b) OVER (ORDER BY procTime() ROWS BETWEEN 2 
> PRECEDING AND CURRENT ROW) FROM stream1`
> Q1.1. `SELECT COUNT(b), SUM( DISTINCT  b) OVER (ORDER BY procTime() ROWS 
> BETWEEN 2 PRECEDING AND CURRENT ROW) FROM stream1`



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to