[ 
https://issues.apache.org/jira/browse/FLINK-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15984782#comment-15984782
 ] 

ASF GitHub Bot commented on FLINK-6250:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3771#discussion_r113446166
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
 ---
    @@ -290,6 +295,10 @@ object AggregateUtil {
         val aggMapping = aggregates.indices.toArray.map(_ + groupings.length)
         val outputArity = aggregates.length + groupings.length + 1
     
    +    // remove when distinct is supported
    +    val distinctAggregatesFlags = new Array[Boolean](aggregates.size)
    --- End diff --
    
    `DataSet` has it's own way to deal with distinct aggregates. They could 
also not initialize the state. So it is save to call `generateAggregations()` 
with an empty array: `Array[Boolean]()` or we make the parameter an 
`Option[Array[Boolean]]` and pass `None`


> Distinct procTime with Rows boundaries
> --------------------------------------
>
>                 Key: FLINK-6250
>                 URL: https://issues.apache.org/jira/browse/FLINK-6250
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: radu
>            Assignee: Stefano Bortoli
>
> Support proctime with rows boundaries
> Q1.1. `SELECT SUM( DISTINCT  b) OVER (ORDER BY procTime() ROWS BETWEEN 2 
> PRECEDING AND CURRENT ROW) FROM stream1`
> Q1.1. `SELECT COUNT(b), SUM( DISTINCT  b) OVER (ORDER BY procTime() ROWS 
> BETWEEN 2 PRECEDING AND CURRENT ROW) FROM stream1`



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to