Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/659#issuecomment-99885222
General comments:
* Let us make sure that the names are somewhat consistent with other
parts of the code. Made inline comments.
* Low watermark concept is "sneaked" into the source interfaces without
mentioning it in the description. :)
* You use `joda.time` which is inconsistent with other parts of the
streaming code. Let us avoid using two time packages.
* These changes need documentation, the source behavior is completely
changed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
