Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/659#discussion_r29856312
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/SourceTest.java
---
@@ -53,18 +47,22 @@ public void fromCollectionTest() {
@Test
public void socketTextStreamTest() throws Exception {
- List<String> expectedList = Arrays.asList("a", "b", "c");
- List<String> actualList = new ArrayList<String>();
-
- byte[] data = { 'a', '\n', 'b', '\n', 'c', '\n' };
-
- Socket socket = mock(Socket.class);
- when(socket.getInputStream()).thenReturn(new
ByteArrayInputStream(data));
- when(socket.isClosed()).thenReturn(false);
- when(socket.isConnected()).thenReturn(true);
-
- new SocketTextStreamFunction("", 0, '\n',
0).streamFromSocket(new MockCollector<String>(
- actualList), socket);
- assertEquals(expectedList, actualList);
+ // TODO: does not work because we cannot set the internal
socket anymore
--- End diff --
This test never tested any actual networking functionality. I actually
started a job with a socket source and it still works as it should.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
