[ 
https://issues.apache.org/jira/browse/FLINK-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14509006#comment-14509006
 ] 

ASF GitHub Bot commented on FLINK-1472:
---------------------------------------

Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/439#issuecomment-95579057
  
    I agree to enforce normalization in the `ConfigConstants`, by adding a test 
case that reflectively gets all fields and checks whether they start with 
"DEFAULT_" or end in "_KEY".
    
    The mapping between keys/values will probably have to be done manually, 
unless we add annotations above the key fields declaring what the default value 
is.
    
    The type of the default value should help to figure out what "get" method 
to use. (getInteger, getDouble) in order to get the correct conversion method.



> Web frontend config overview shows wrong value
> ----------------------------------------------
>
>                 Key: FLINK-1472
>                 URL: https://issues.apache.org/jira/browse/FLINK-1472
>             Project: Flink
>          Issue Type: Bug
>          Components: Webfrontend
>    Affects Versions: master
>            Reporter: Ufuk Celebi
>            Assignee: Mingliang Qi
>            Priority: Minor
>
> The web frontend shows configuration values even if they could not be 
> correctly parsed.
> For example I've configured the number of buffers as "123.000", which cannot 
> be parsed as an Integer by GlobalConfiguration and the default value is used. 
> Still, the web frontend shows the not used "123.000".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to