[ 
https://issues.apache.org/jira/browse/FLINK-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14508756#comment-14508756
 ] 

ASF GitHub Bot commented on FLINK-1472:
---------------------------------------

Github user aljoscha commented on the pull request:

    https://github.com/apache/flink/pull/439#issuecomment-95517673
  
    Hi,
    sorry for the long wait on this. I really like the feature but the 
implementation is not scalable: If new config values are added this needs to be 
updated in several places now.
    
    Could you change ConfigConstants and add a static initializer block that 
builds the hash maps that you manually build in DefaultConfigKeyValues using 
reflection. The code would just need to loop through all fields that have _KEY 
at the end, and then find the matching default value without the _KEY at the 
end. From the default value field the type of the value can be determined and 
it can be added to the appropriate hash map. This way, the defaults will always 
stay up to date with the actual config constants.


> Web frontend config overview shows wrong value
> ----------------------------------------------
>
>                 Key: FLINK-1472
>                 URL: https://issues.apache.org/jira/browse/FLINK-1472
>             Project: Flink
>          Issue Type: Bug
>          Components: Webfrontend
>    Affects Versions: master
>            Reporter: Ufuk Celebi
>            Assignee: Mingliang Qi
>            Priority: Minor
>
> The web frontend shows configuration values even if they could not be 
> correctly parsed.
> For example I've configured the number of buffers as "123.000", which cannot 
> be parsed as an Integer by GlobalConfiguration and the default value is used. 
> Still, the web frontend shows the not used "123.000".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to