devi-pathak2263 commented on PR #5638: URL: https://github.com/apache/fineract/pull/5638#issuecomment-4136422821
> Hi, I was reviewing this PR and noticed that updating the approved amount with the same value still triggers history creation and business events. > > I’ve created a small follow-up improvement to prevent no-op updates by adding validation when the new approved amount equals the current value. Also added integration test coverage for this scenario. > > PR: #5696 (follow-up improvement) > > Please let me know if this aligns with the intended behavior. Just a quick update: based on the feedback, I’ve created a separate JIRA issue for this improvement (FINERACT-2556) and updated the PR accordingly. PR: [#5696](https://github.com/apache/fineract/pull/5696) Thanks again for the guidance! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
