meonkeys commented on PR #5638: URL: https://github.com/apache/fineract/pull/5638#issuecomment-4119207666
@adamsaghy wrote: > Assuming this is the wanted behaviour, since you are the author of the merge commit. Anyway the original commit still authored by Peter, but now there are multiple commits. > > @meonkeys right? That's right. @vidakovic wrote: > @meonkeys also: should I just leave then the default messages that is provided to me (was something like "Merge: [FINERACT-1234](https://issues.apache.org/jira/browse/FINERACT-1234) blablabla", but also repeated the commit/PR titles in the extended description)... looks a bit weird and unnecessary given the already existing commit(s) with description(s). Any recommendations/preferences? Aleks, I like what you did with merge commit 2e718325b55f743721dd7d578617b5d5597f93f9, and I'd also leave the rest of the autogenerated commit log message below that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
