[ https://issues.apache.org/jira/browse/CXF-4431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421520#comment-13421520 ]
Sergey Beryozkin commented on CXF-4431: --------------------------------------- Hi, here is the initial commit to the trunk: http://svn.apache.org/viewvc?rev=1365160&view=rev will merge it later to 2.6.x. Here are some comments on the modifications I did: - Made relevant updates to get the latest draft supported - I did quite a few refactorings, mainly to get all the Hmac and normalization work done in one or two places. - I did not introduce mac specific properties into ClientAccessToken - it needs to be able to manage not only bearer/mac, but other types too, it has the typed well-known properties all token share and then a map of parameters for keeping the token specific extensions - I've not added a NonceVerifier implementation yet, only the interface. I think the implementation is actually pretty advanced :-), which is good, but I guess we need to think a bit more about whether we should ship it with CXF or may be as part of the demo - may be we should get ECache-based store added, etc, need to think more - plus few other bits and pieces Hope you will won't be disappointed with the changes I did. Overall it's a very good contribution - thanks for the effort. Few more minor updates may need to be done, like the queries normalization, etc, but it's nearly there. As a side note - I'd like to review if we can get this Mac-specific code available to other OAuth projects once it settles down a bit, we can discuss it offline, I'll ping you here or please ping me later on. > Add support for OAuth2 'mac' token type > --------------------------------------- > > Key: CXF-4431 > URL: https://issues.apache.org/jira/browse/CXF-4431 > Project: CXF > Issue Type: Improvement > Components: JAX-RS, JAX-RS Security > Affects Versions: 2.6.1 > Reporter: Sasi M > Fix For: 2.7.0 > > Attachments: mac_token_nonce_checking.txt, mac_token_support.txt > > > CXF currently supports only the Bearer token type. This token type is not > feasible for use without SSL. > OAuth2 specs out the 'mac' token type that requires request signing for > authentication using the access token. The spec is described here: > http://tools.ietf.org/html/draft-ietf-oauth-v2-http-mac-01 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira