dpogue commented on code in PR #1667:
URL: https://github.com/apache/cordova-ios/pull/1667#discussion_r3438203129
##########
CordovaLib/Classes/Public/CDVViewController.m:
##########
@@ -577,7 +577,7 @@ - (void)onWebViewPageDidLoad:(NSNotification*)notification
- (void)scrollViewDidChangeAdjustedContentInset:(UIScrollView *)scrollView
{
-#ifndef TARGET_OS_VISION
+#if !defined(TARGET_OS_VISION) || !TARGET_OS_VISION
Review Comment:
I don't know if there's much benefit to defining our own macro in addition
to the ones Apple already defines, which are well established convention across
their platforms
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
