dpogue commented on code in PR #1667:
URL: https://github.com/apache/cordova-ios/pull/1667#discussion_r3408590497
##########
CordovaLib/Classes/Public/CDVViewController.m:
##########
@@ -577,7 +577,7 @@ - (void)onWebViewPageDidLoad:(NSNotification*)notification
- (void)scrollViewDidChangeAdjustedContentInset:(UIScrollView *)scrollView
{
-#ifndef TARGET_OS_VISION
+#if !TARGET_OS_VISION
Review Comment:
This is _probably_ fine as-is, but the safer thing to do would be check `#if
!defined(TARGET_OS_VISION) || !TARGET_OS_VISION` so that it doesn't caused
undefined macro warnings if using an SDK that predates visionOS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
