erisu opened a new pull request, #1854: URL: https://github.com/apache/cordova-android/pull/1854
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> Re-add support for pollOnce which was broken for 12 years and not used. Resolves #1735 Closes #1746 ### Description <!-- Describe your changes in detail --> - Expose the `pollOnce` method that was relocated into `cordova-js-src/exec.js` 12 years ago. - Update `framework/src/org/apache/cordova/NativeToJsMessageQueue.java` to require the new location of `pollOnce` ### Testing <!-- Please describe in detail how you tested your changes. --> - `npm t` - Built app and called manually `window.setTimeout(function(){cordova.require('cordova/exec').pollOnce();},0);` - I don't have an actual use case to trigger the `popAndEncodeAsJs` naturally to test. ### Checklist - [x] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
