erisu opened a new pull request, #1853: URL: https://github.com/apache/cordova-android/pull/1853
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> Fixing of the following cases in status bar implementation: - `padStart` is not supported in SDK 24's default WebView version. - Project's that some how renames`cordova.js` and wouldn't be detected. ### Description <!-- Describe your changes in detail --> - Replaced `padStart` with logic that is supported by SDK 24. This should be replaced with `padStart` when SDK 24 is dropped. - When `cordova.js` is loaded, or what ever the file name maybe, the statusbar portion will automatically create a script block and inject it to the head. The reference of this block is stored internally so that the `setBackgroundColor` may use it to compute the color. It no longer relies on the filename. > Note: Third-party plugins should not try to locate and manipulate this script block as the implementation could change in the future, depending on what JS support we have access to in the future. ### Testing <!-- Please describe in detail how you tested your changes. --> - `npm t` - Running emulators, 24, 25, 26, ... 34, 35, 36 and changing statusbar background color. ### Checklist - [x] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
