breautek commented on code in PR #1523: URL: https://github.com/apache/cordova-ios/pull/1523#discussion_r2416973641
########## cordova-js-src/plugin/ios/statusbar.js: ########## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + * + */ + +var exec = require('cordova/exec'); + +var statusBarVisible = true; +var statusBar = {}; + +Object.defineProperty(statusBar, 'visible', { + configurable: false, + enumerable: true, + get: function () { + if (window.StatusBar) { + // Let the CDVStatusBar plugin handle it + return window.StatusBar.isVisible; + } + + return statusBarVisible; + }, + set: function (value) { + if (window.StatusBar) { + // Let the CDVStatusBar plugin handle it + if (value) { + window.StatusBar.show(); + } else { + window.StatusBar.hide(); + } + } else { + statusBarVisible = value; + exec(null, null, 'StatusBarInternal', 'setVisible', [!!value]); + } + } +}); + +Object.defineProperty(statusBar, 'setBackgroundColor', { + configurable: false, + enumerable: false, + writable: false, + value: function (value) { + var script = document.querySelector('script[src$="cordova.js"]'); Review Comment: It looks like we are just attaching styles to keep track of state? Or am I missing something? If we are just keeping track of state then... We could just remove the dependency on cordova.js here and use [CSS vars](https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_cascading_variables/Using_CSS_custom_properties#values_in_javascript), or even attach [data-](https://developer.mozilla.org/en-US/docs/Web/HTML/How_to/Use_data_attributes). The CSS vars can be set on the `:root` element, for example: ``` document.querySelector(':root').style.setProperty("--cordova-statusbar-color"); ``` Or we can attach a `data-cordova-statusbar-color` on the HTML/body node or somewhere easily accessible. Both solutions won't interfere with user apps (unless if they clash on naming, hence the `cordova` prefix), and then `setBackgroundColor` api becomes decoupled from cordova.js. The CSS vars path has an added benefit of having that state available to CSS, so users could reference for their own UI, to match colour scheme or whatever. But if we do that, then we need to make sure that every way that manipulates the status bar colour will update the CSS var accordingly, otherwise it will just be a source of bug reports. The data attribute path would just be a simple way to store state into the DOM. Or maybe this is also over-engineering. What's wrong with a local JS variable? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
