breautek commented on code in PR #1523: URL: https://github.com/apache/cordova-ios/pull/1523#discussion_r2417303520
########## cordova-js-src/plugin/ios/statusbar.js: ########## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + * + */ + +var exec = require('cordova/exec'); + +var statusBarVisible = true; +var statusBar = {}; + +Object.defineProperty(statusBar, 'visible', { + configurable: false, + enumerable: true, + get: function () { + if (window.StatusBar) { + // Let the CDVStatusBar plugin handle it + return window.StatusBar.isVisible; + } + + return statusBarVisible; + }, + set: function (value) { + if (window.StatusBar) { + // Let the CDVStatusBar plugin handle it + if (value) { + window.StatusBar.show(); + } else { + window.StatusBar.hide(); + } + } else { + statusBarVisible = value; + exec(null, null, 'StatusBarInternal', 'setVisible', [!!value]); + } + } +}); + +Object.defineProperty(statusBar, 'setBackgroundColor', { + configurable: false, + enumerable: false, + writable: false, + value: function (value) { + var script = document.querySelector('script[src$="cordova.js"]'); Review Comment: I see. In that case, we can still decouple from `cordova.js` by dynamically creating a HTML node. It can have something like: ``` let statusbarTool = document.createElement('div'); statusbarTool.id = 'cdv-status-bar-tool'; // Identifier for lookup later. // styling to place the node off screen statusbarTool.style.position = 'fixed'; statusbarTool.style.top = '-200%'; statusbarTool.style.left = -200%'; // Ensure the node isn't interactable... some how via tabbing or whatever statusbarTool.style.touchAction = 'none; statusbarTool.style.pointerEvents = 'none'; // Ensure the node isn't painted whatsoever statusbarTool.style.display = 'none'; document.body.appendChild(statusbarTool); ``` Bonus points if this is lazy-loaded behind a getter that creates the node if `'cdv-status-bar-tool'` cannot be found. This way we have a node "owned" by cordova-ios to assist in the status bar api. It shouldn't interfere with the app in both of visual and interactions... and you should be able to apply the styling to use `getComputedStyle`... Though I also do wonder if it's safe to assume you'll get a `RGB` format back from `getComputedStyle`... That seems like an web engine implementation detail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
