erisu commented on PR #291: URL: https://github.com/apache/cordova-plugin-geolocation/pull/291#issuecomment-2832463309
I will merge this PR as is. The failing iOS tests are unrelated to this PR. I believe the failing iOS tests are due to the location permission not being approved. When running the tests manually, a permission dialog appears. If the permission is approved, the tests pass. If ignored, the tests time out, showing the same results we see in GitHub Actions. I believe we will need to figure out a way to configure permission approvals at the plugin's workflow level, using information that is passed to Paramedic. For example, we can approve the location permission using the following terminal command: ```bash xcrun simctl privacy booted grant location io.cordova.hellocordova ``` We would need to run the above command after the app is installed on the simulator but before the app is launched. This work is out of scope for this PR and would require further investigation, discussion, and possibly raising it on the dev mailing list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
