erisu commented on PR #291: URL: https://github.com/apache/cordova-plugin-geolocation/pull/291#issuecomment-2827376314
Thank you, Also, for your changes, could make sure that its based on the following default template? I don't think you are missing anything but could try and drop the file contents in to make sure. https://github.com/apache/cordova-paramedic/blob/master/.github/workflows/ios.yml For the most part, I think all your changes follows everything base template, except for `maxim-lobanov/setup-xcode`. We need to keep it pinned to the same commit ID that's used in Paramedic default template. **Why commit-hash ID:** The Apache Software Foundation is moving toward blocking tags like `v1` and prefers commit hash IDs instead. Not all GitHub Actions have been updated to reflect this yet, and I was planning to look into it. This requirement, as I understand it, mainly applies to third-party actions — I believe GitHub’s core actions (e.g. `actions/checkout`) won’t be required to use commit hashes. ### For Additional Information Apache Cordova's base configurations always originate from **Paramedic**, so we try to keep them identical. If we're planning to make changes, Cordova usually updates Paramedic first to set the default template, and then we apply the updates across all plugins. There are only a few exceptions where plugins have slight differences — for example, the **File Transfer** plugin, but they would be altered based on the default template. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
