GitToTheHub commented on code in PR #1360:
URL: https://github.com/apache/cordova-docs/pull/1360#discussion_r1830769891


##########
www/docs/en/dev/guide/platforms/android/index.md:
##########
@@ -284,14 +284,21 @@ _**Note:** The directories above are generally located in 
the Android SDK ROOT._
 
 #### macOS and Linux
 
-On a Mac or Linux, with a text editor, create or modify the `~/.bash_profile` 
file.
+On a Mac older then Catalina or on Linux, create or modify the 
`~/.bash_profile` file for e.g. with a text editor.
+On macOS Catalina and newer, create or modify the `~/.zprofile`, because it's 
using ZSH instead of Bash.
 
 To set an environment variable, add a line that uses `export` like so 
(substitute the path with your local installation):
 
 ```bash
 export ANDROID_HOME=/Development/android-sdk/
 ```
 
+on macOS
+
+```zsh
+export ANDROID_HOME=~/Library/Android/sdk/
+```
+

Review Comment:
   Could there be not suggestions for the different OSs? It is more helpful, if 
the Guide already takes you to the right place of your SDK.
   I overhead the part "substitute the path with your local installation". But 
the example `ANDROID_HOME=/path/to/android-sdk/`would make it more clear



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to