erisu commented on code in PR #1360: URL: https://github.com/apache/cordova-docs/pull/1360#discussion_r1830487130
########## www/docs/en/dev/guide/platforms/android/index.md: ########## @@ -284,14 +284,21 @@ _**Note:** The directories above are generally located in the Android SDK ROOT._ #### macOS and Linux -On a Mac or Linux, with a text editor, create or modify the `~/.bash_profile` file. +On a Mac older then Catalina or on Linux, create or modify the `~/.bash_profile` file for e.g. with a text editor. Review Comment: ```suggestion On macOS versions prior to Catalina or on Linux, use any text editor to create or modify the `~/.bash_profile` file. ``` ########## www/docs/en/dev/guide/platforms/android/index.md: ########## @@ -284,14 +284,21 @@ _**Note:** The directories above are generally located in the Android SDK ROOT._ #### macOS and Linux -On a Mac or Linux, with a text editor, create or modify the `~/.bash_profile` file. +On a Mac older then Catalina or on Linux, create or modify the `~/.bash_profile` file for e.g. with a text editor. +On macOS Catalina and newer, create or modify the `~/.zprofile`, because it's using ZSH instead of Bash. Review Comment: ```suggestion On macOS Catalina and newer, create or modify the `~/.zprofile` file instead, as the default shell has changed. ``` ########## www/docs/en/dev/guide/platforms/android/index.md: ########## @@ -284,14 +284,21 @@ _**Note:** The directories above are generally located in the Android SDK ROOT._ #### macOS and Linux -On a Mac or Linux, with a text editor, create or modify the `~/.bash_profile` file. +On a Mac older then Catalina or on Linux, create or modify the `~/.bash_profile` file for e.g. with a text editor. +On macOS Catalina and newer, create or modify the `~/.zprofile`, because it's using ZSH instead of Bash. To set an environment variable, add a line that uses `export` like so (substitute the path with your local installation): ```bash export ANDROID_HOME=/Development/android-sdk/ ``` +on macOS + +```zsh +export ANDROID_HOME=~/Library/Android/sdk/ +``` + Review Comment: This section may be unnecessary, as the previous line instructs to "substitute the path with your local installation." The example path, `/Development/android-sdk/`, as far as I am aware is not a standard or default path, even on Linux. It was only for an example. I believe it was intended to account for users who set up their Android development environment with `cmdline-tools` rather than Android Studio. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
