jcesarmobile commented on code in PR #1696:
URL: https://github.com/apache/cordova-android/pull/1696#discussion_r1521318277
##########
framework/src/org/apache/cordova/engine/SystemWebViewClient.java:
##########
@@ -116,6 +118,18 @@ public SystemWebViewClient(SystemWebViewEngine
parentEngine) {
});
this.assetLoader = assetLoaderBuilder.build();
+ boolean setAsServiceWorkerClient =
parentEngine.preferences.getBoolean("ResolveServiceWorkerRequests", false);
Review Comment:
I've set it to be the same default value as `cordova-plugin-ionic-webview`
in case people is migrating from there, but if we want it to be `true` and it's
not going to be released as a minor, I can change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
