breautek commented on code in PR #1696:
URL: https://github.com/apache/cordova-android/pull/1696#discussion_r1504301121
##########
framework/src/org/apache/cordova/engine/SystemWebViewClient.java:
##########
@@ -116,6 +118,18 @@ public SystemWebViewClient(SystemWebViewEngine
parentEngine) {
});
this.assetLoader = assetLoaderBuilder.build();
+ boolean setAsServiceWorkerClient =
parentEngine.preferences.getBoolean("ResolveServiceWorkerRequests", false);
Review Comment:
I feel like if this is going to be introduced in the 13.x release then we
could default to `true` so that service workers just "works" out of the box.
But I don't have a strong opinion to block this and I'm okay if this remains
using `false` as a default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
