[
https://issues.apache.org/jira/browse/IMAGING-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115767#comment-16115767
]
ASF GitHub Bot commented on IMAGING-168:
----------------------------------------
Github user kinow commented on a diff in the pull request:
https://github.com/apache/commons-imaging/pull/18#discussion_r131540224
--- Diff:
src/main/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcParser.java ---
@@ -248,6 +258,35 @@ public PhotoshopApp13Data parsePhotoshopSegment(final
byte[] bytes,
return elements;
}
+ private String getEncodingCharsetName(byte[] codedCharacterSet){
+ final Character WHITESPACE = ' ';
+ String codedCharacterSetString = new String(codedCharacterSet);
+ try {
+ if (Charset.isSupported(codedCharacterSetString)) {
+ return codedCharacterSetString;
+ }
+ }catch (IllegalCharsetNameException e){
+
--- End diff --
Might be worth to add at least one comment saying why these exceptions are
not important, and that can be safely ignored.
> IPTC parser should use CodedCharacterSet tag to determine encoding of the
> IPTC tag values
> -----------------------------------------------------------------------------------------
>
> Key: IMAGING-168
> URL: https://issues.apache.org/jira/browse/IMAGING-168
> Project: Commons Imaging
> Issue Type: Bug
> Components: Format: JPEG
> Reporter: sudeep khemka
> Fix For: Review Patch
>
> Attachments: codedCharacterSet.patch
>
>
> The IPTC CodedCharacterSet tag can be used to specify the encoding of the
> IPTC tag values. But the setting is currently ignored.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
