[jira] [Commented] (IMAGING-168) IPTC parser should use CodedCharacterSet tag to determine encoding of the IPTC tag values

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/IMAGING-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115768#comment-16115768
 ] 

ASF GitHub Bot commented on IMAGING-168:
----------------------------------------

Github user kinow commented on a diff in the pull request:

    https://github.com/apache/commons-imaging/pull/18#discussion_r131540245
  
    --- Diff: 
src/main/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcRecord.java ---
    @@ -50,6 +50,10 @@ public IptcRecord(final IptcType iptcType, final String 
value) {
             this.value = value;
         }
     
    +    public IptcRecord(final IptcType iptcType, final String value) {
    +        this(iptcType, value, "ISO-8859-1");
    --- End diff --
    
    +1 there is a constant defined in another class, but I wonder if we could 
use `StandardCharsets` as `commons-imaging` is using Java1.7+.


> IPTC parser should use CodedCharacterSet tag to determine encoding of the 
> IPTC tag values
> -----------------------------------------------------------------------------------------
>
>                 Key: IMAGING-168
>                 URL: https://issues.apache.org/jira/browse/IMAGING-168
>             Project: Commons Imaging
>          Issue Type: Bug
>          Components: Format: JPEG
>            Reporter: sudeep khemka
>             Fix For: Review Patch
>
>         Attachments: codedCharacterSet.patch
>
>
> The IPTC CodedCharacterSet tag can be used to specify the encoding of the 
> IPTC tag values. But the setting is currently ignored.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)