rootvector2 opened a new pull request, #782: URL: https://github.com/apache/commons-vfs/pull/782
`createSSLContext` loads its trust material through `TrustAllStrategy`, so `http4s`, `http5s` and `webdav4s` accept any certificate chain and the default-on `DefaultHostnameVerifier` is all that stands between a client and a self-signed certificate minted for the target host, which is why `Http5sGetContentInfoTest` still reads from www.apache.org while pinning nothing but a `*.apache.org` trust anchor that expired in 2021, found while auditing these providers against `FtpsFileSystemConfigBuilder` which already defaults to `TrustManagerUtils.getValidateServerCertificateTrustManager()`, and the fix drops the strategy so the configured keystore, or else the JVM default trust store, decides. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [x] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [x] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? Claude Code, to audit the TLS setup of the http providers and to draft this patch and its tests; I reviewed the result and verified it against the build. - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
