lenamonj opened a new pull request, #1787: URL: https://github.com/apache/commons-lang/pull/1787
Follow-up to #1784. The zero shortcuts in `addSub` returned the other operand as constructed, so `ZERO.add(2/4)` was `2/4` against the Javadoc's reduced-form promise, and `ZERO.subtract(Integer.MIN_VALUE/2)` threw although the reduced result `1073741824/1` fits, both noted in the #1784 review. The shortcuts now reduce before returning or negating. The new test covers both operations with zero on either side and the `Integer.MIN_VALUE` boundary; it fails on master and passes with the change. Default `mvn` goal green with `-Ddoclint=all`. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [x] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [x] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? Claude (Anthropic) wrote the fix and the test from the #1784 review and ran the reproduction and the default Maven goal on a fresh clone; I directed and reviewed the work. - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
