lenamonj opened a new pull request, #736: URL: https://github.com/apache/commons-collections/pull/736
`previousKey` carries the defect #728 fixed in `nextKey`. `AbstractSortedMapDecorator.previousKey` returns `headMap(key).lastKey()` without checking that `key` is present, so an absent key inside the range returns its predecessor and a key outside a range-restricted view throws `IllegalArgumentException`; `DualTreeBidiMap.previousKey` fails the same way. `OrderedMap` documents `null` for a key with no match, and every other `previousKey` in the library returns it. Return `null` when the map does not contain `key`, and use `NavigableMap.lowerKey` when the decorated map offers it, mirroring #728 line for line. Tests: both ordered-map conformance suites now assert the absent-key case on a full map, plus four explicit tests; red on master and green with the change. Default Maven goal green. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [x] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [x] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? Claude (Anthropic) found the defect and drafted the fix and tests; I reviewed them, reproduced the failure on a fresh clone of master, and ran the default Maven goal. - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
