rootvector2 opened a new pull request, #735: URL: https://github.com/apache/commons-collections/pull/735
`StaticBucketMap` extends `AbstractIterableMap` and never overrides the `java.util.Map` defaults, so `putIfAbsent`, `compute`, `computeIfAbsent`, `computeIfPresent`, `merge`, `remove(key, value)`, both `replace` overloads and `getOrDefault` release the bucket monitor between their nested `get` and `put` calls and lose concurrent updates on a map whose javadoc says not to wrap it in `Collections.synchronizedMap` (found while checking which thread-safe classes override the `Map` defaults; 8 threads doing 20000 `merge(key, 1, Integer::sum)` each finish near 41000 instead of 160000), so each of them now runs the inherited default inside `synchronized (locks[getHash(key)])`, while `forEach` and `replaceAll` stay as they are because bulk operations are documented as non-atomic. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [x] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [x] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? Claude Code (Anthropic) was used for the whole change: it found the issue, drafted the overrides and the test, and ran the reproducer and the full default Maven goal. - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
