garydgregory commented on PR #432: URL: https://github.com/apache/commons-cli/pull/432#issuecomment-5266682494
Hello @farkhalit Thank you for the update to this PR. You may have missed my earlier comment, so I'll restate it here. To demonstrate that this change is effective, we need a test that shows what an application using the public (or protected) CLI API looks like, and then verifies that the class has not actually been initialized after the command line has been parsed and queried. Testing the low-level converters is fine, but IMO it is ultimately moot if the end goal (preventing class initialization at the application level) is not demonstrated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
