farkhalit commented on code in PR #432:
URL: https://github.com/apache/commons-cli/pull/432#discussion_r3763847230


##########
src/main/java/org/apache/commons/cli/Converter.java:
##########
@@ -43,9 +43,10 @@ public interface Converter<T, E extends Exception> {
     Converter<?, RuntimeException> DEFAULT = s -> s;
 
     /**
-     * Converts a String to a {@link Class}. Calls {@link 
Class#forName(String)}.
+     * Converts a String to a {@link Class}. Calls {@link 
Class#forName(String, boolean, ClassLoader)} with {@code initialize} set to 
{@code false} so that
+     * naming a class does not run its static initializer.

Review Comment:
   Good point, reworded it to "resolving the name does not by itself trigger 
the class's static initializer" so it doesn't imply the class can never already 
be initialized.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to