rootvector2 opened a new pull request, #423: URL: https://github.com/apache/commons-beanutils/pull/423
`PointConverter.convertToType` splits the inner coordinate string with `POINT_SPLIT.split(coordinates)`, and `String.split` with the default limit drops trailing empty tokens. A trailing separator after the two coordinates is swallowed, so `(100,200,)` and `(100,200,,)` parse to `Point(100,200)`. That is inconsistent with `(100,)`, which is already rejected because it yields a single token. Pass `-1` as the split limit so trailing empties are kept and the existing `xy.length != 2` check rejects the malformed input. Keeping the bound in the converter means every caller gets the same validation, and valid `(x,y)` forms are unchanged. Found while auditing the awt converters alongside `ColorConverter`. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
