rootvector2 opened a new pull request, #526: URL: https://github.com/apache/commons-bcel/pull/526
`IINC.setIncrement` stores the increment without checking its range, but `dump` writes the wide-form increment with `writeShort`. The wide `iinc` increment is a signed short, so `new IINC(0, 40000)` (or `setIncrement` with any value outside `-32768..32767`) is accepted and `getIncrement` still returns `40000`, yet `dump` emits `-25536`. Found while auditing the operand setters around the earlier `setIndex` bounds fix; the increment is the one that was left unchecked. Reject an out-of-range increment in `setIncrement` with the same `isValidShort` guard `BranchInstruction.dump` and the sibling `setIndex` already use. The two-arg constructor routes through `setIncrement`, so checking it there covers every construction path. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
