garydgregory commented on PR #1532: URL: https://github.com/apache/commons-lang/pull/1532#issuecomment-3693028054
Hi @jher235 Your PR is specifically making performance claims for 8 methods. Each claim should provide evidence. The fact that the changes follow the same pattern doesn't matter since the types are different and may be handled differently by the compiler and JVM. This is a bit like claiming bug fixes in 8 similar methods but only providing unit tests for a subset of the changed methods. HTH & Happy Holidays 👍 🎉 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
