garydgregory commented on PR #1532: URL: https://github.com/apache/commons-lang/pull/1532#issuecomment-3691565058
Hello @jher235 Thank you for your changes. These are incomplete. You are only covering 2 of the 8 primitive types for the 2 out of the 8 methods you've changed. I completed and improved the benchmark. See git master or [snapshot](https://repository.apache.org/content/repositories/snapshots/) builds. You are credited in `changes.xml`. I've also made the buffer allocation for all methods consistent. I believe this PR can be closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
