pbaumard commented on PR #743:
URL: https://github.com/apache/commons-io/pull/743#issuecomment-2850477214

   > @pbaumard Please do not remove assertions.
   
   I thought at first that those removed assertions were useless since they 
were flagged by SonarLint 
([RSPEC-5845](https://rules.sonarsource.com/java/RSPEC-5845/) and 
[RSPEC-5863](https://rules.sonarsource.com/java/RSPEC-5863/)).
   I added them back and also added some new assertions to get a 100% coverage.
   It could be better to move the equals and hashCode tests to some new method 
to make the intent clearer. For now I just added some comments.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to