pbaumard commented on PR #743:
URL: https://github.com/apache/commons-io/pull/743#issuecomment-2850241160

   > @pbaumard Please do not remove assertions.
   
   I don't see the point of the removed assertions, which are flagged by 
[SonarQube IDE](https://www.sonarsource.com/fr/products/sonarlint/) :
   
   "Assertions should not compare an object to itself" 
([RSPEC-5863](https://rules.sonarsource.com/java/RSPEC-5863/))
   
   ```java
   assertEquals(visitFileTree, visitFileTree);
   ```
   
   "Assertions comparing incompatible types should not be made" 
([RSPEC-5845](https://rules.sonarsource.com/java/RSPEC-5845/))
   
   ```java
   assertNotEquals(visitFileTree, "not");
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to